feat(tangle-dapp): Bridge revamp & Router integration #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
yurixander
approved these changes
Dec 14, 2024
| import { BridgeChainsConfigType, BridgeTokenType } from './types'; | ||
| import { Abi } from 'viem'; | ||
|
|
||
| const asAbi = (abi: any): Abi => abi as Abi; |
There was a problem hiding this comment.
Is there any way to avoid using any here? Does it show you an error otherwise?
| const routerQuoteParams = { | ||
| fromTokenAddress, | ||
| toTokenAddress, | ||
| amountInWei: amount?.toString() ?? '', |
There was a problem hiding this comment.
What will happen in the case that the amount is an empty string?
Comment on lines
186
to
190
| amount: Number(amount?.toString() ?? '0'), | ||
| sourceTypedChainId, | ||
| destinationTypedChainId, | ||
| senderAddress: activeAccount?.address ?? '', | ||
| recipientAddress: destinationAddress ?? '', |
There was a problem hiding this comment.
What will happen when the amount is zero or the addresses are empty strings? Should we be handling these edge cases explicitly instead?
| } | ||
|
|
||
| export type RouterTransferProps = { | ||
| routerQuoteData: any; |
There was a problem hiding this comment.
Is there are structured data type for this?
| @@ -81,7 +82,9 @@ export type LocalStorageValueOf<T extends LocalStorageKey> = | |||
| ? LiquidStakingTableData | |||
| : T extends LocalStorageKey.ONBOARDING_MODALS_SEEN | |||
| ? OnboardingPageKey[] | |||
| : never; | |||
| : T extends LocalStorageKey.EVM_TOKEN_BALANCES | |||
| ? Record<string, any> | |||
There was a problem hiding this comment.
Is there any structured data type for this?
added 2 commits
December 15, 2024 06:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Proposed area of change
apps/tangle-dappapps/tangle-cloudlibs/tangle-shared-uilibs/webb-ui-components